Skip to content

Provide a logbook option entity_matches_only to optimize for single entity lookup#39555

Merged
bdraco merged 4 commits intohome-assistant:devfrom
bdraco:logbook_entity_matches_only
Sep 2, 2020
Merged

Provide a logbook option entity_matches_only to optimize for single entity lookup#39555
bdraco merged 4 commits intohome-assistant:devfrom
bdraco:logbook_entity_matches_only

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Sep 1, 2020

For home-assistant/frontend#6758

Proposed change

Provide a logbook option entity_matches_only to optimize for single entity lookup

When entity_matches_only is provided, contexts and events that do not
contain the entity_id are not included in the logbook response.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

…ntity id lookup

When entity_matches_only is provided, contexts and events that do not
contain the entity_id are not included in the logbook response.
@bdraco bdraco merged commit 45c28dd into home-assistant:dev Sep 2, 2020
leikoilja pushed a commit to leikoilja/core that referenced this pull request Sep 6, 2020
…ntity lookup (home-assistant#39555)

* Provide a logbook option entity_matches_only to optimize for single entity id lookup

When entity_matches_only is provided, contexts and events that do not
contain the entity_id are not included in the logbook response.

* Update homeassistant/components/logbook/__init__.py

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>

* api only takes a single entity

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants